Separate creation & usage of OxDispatcher #3759
Merged
+29
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamw
changed the title
|
Is the confusion caused by seeing a |
|
No, the confusion comes from the fact that when I navigate to OxDispathcer from usage-site (where .runAsync) is invoked, I see a captured |
kciesielski
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever I read OxDispatcher code I got a bit confused, and got worried that the captured
Oxscope is going to be used when calling.runAsyncon another thread.Separating creation of the dispatcher (where the scope needs to be captured) from scheduling computations (where we just need to send a message to an actor on a channel) maybe will clarify this for future users (and me ;) )